Fix several issues related to schema loading in declarative #5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6861cf05761f9f1d73416f23ab6ab65396d44e21.
aljazerzen
reviewed
May 30, 2023
elprans
reviewed
May 31, 2023
edb/edgeql/tracer.py
Outdated
| @@ -461,6 +469,8 @@ def _fork_context(ctx: TracerContext) -> TracerContext: | |||
| schema=ctx.schema, | |||
| module=ctx.module, | |||
| objects=dict(ctx.objects), | |||
| # XXX? | |||
There was a problem hiding this comment.
Can you elaborate the XXX or remove it?
elprans
approved these changes
May 31, 2023
msullivan
added a commit
that referenced
this pull request
Jun 1, 2023
The main change is a new schema where if we can't figure out the type of an expression in a path, create weak dependencies to all pointers with the same name. This doesn't always work but in practice it will do very well. I have some ideas for how we could incorporate correct typechecking into schema loading, but in the mean time this probably solves 90% of the problem at least. Fixes #4683. Fixes #5163.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is a new schema where if we can't figure out the type
of an expression in a path, create weak dependencies to all pointers
with the same name.
This doesn't always work but in practice it will do very well.
I have some ideas for how we could incorporate correct typechecking
into schema loading, but in the mean time this probably solves 90% of
the problem at least.
In this PR there is also a commit that adds a system for categorizing
objects so that things without expressions will go first, and things
with expressions will be prioritized based on whether they can be
referred to.
I wound up reverting it because it isn't needed to fix the issues that
weak pointers fix, and other than those, I think it mostly would work
around bugs that could be fixed in straightforward ways.
Fixes #4683. Fixes #5163.