-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named tuple params whose types also appear in the schema don't work #5789
Comments
With the schema
we get basically that error with
With
we get and with
we get |
msullivan
added a commit
that referenced
this issue
Aug 26, 2023
The tuple argument decoder code simply ignores whether a tuple is named, figuring that named tuples and unnamed tuples have the same representation in the generated SQL, so why bother. (It was called out as a "HACK" in the comments.) But they only have the same representation when they are represented as a `record`. If the tuple type appears in the schema, it gets represented as a named composite type and we no longer have the right representation. Just do it right. Fixes #5789.
msullivan
added a commit
that referenced
this issue
Aug 30, 2023
The tuple argument decoder code simply ignores whether a tuple is named, figuring that named tuples and unnamed tuples have the same representation in the generated SQL, so why bother. (It was called out as a "HACK" in the comments.) But they only have the same representation when they are represented as a `record`. If the tuple type appears in the schema, it gets represented as a named composite type and we no longer have the right representation. Just do it right. Fixes #5789.
msullivan
added a commit
that referenced
this issue
Sep 2, 2023
The tuple argument decoder code simply ignores whether a tuple is named, figuring that named tuples and unnamed tuples have the same representation in the generated SQL, so why bother. (It was called out as a "HACK" in the comments.) But they only have the same representation when they are represented as a `record`. If the tuple type appears in the schema, it gets represented as a named composite type and we no longer have the right representation. Just do it right. Fixes #5789.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to Reproduce:
Schema:
Query with Typescript Query Builder:
EdgeQL query:
Error:
The text was updated successfully, but these errors were encountered: