Avoid unnecessary updates to parent views and triggers #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For parent views, when scheduling inhview updates, instead of finding all ancestors of the source, find all sources of the ancestors. This avoids doing silly things like updating BaseObject's view when a property is added to any type. For triggers, fix an optimization that avoids updating everything on changes to inherited links.
elprans
approved these changes
Apr 20, 2022
msullivan
added a commit
that referenced
this pull request
Apr 21, 2022
For parent views, when scheduling inhview updates, instead of finding all ancestors of the source, find all sources of the ancestors. This avoids doing silly things like updating BaseObject's view when a property is added to any type. For triggers, fix an optimization that avoids updating everything on changes to inherited links.
msullivan
added a commit
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parent views, when scheduling inhview updates, instead of finding
all ancestors of the source, find all sources of the ancestors. This
avoids doing silly things like updating BaseObject's view when a
property is added to any type.
For triggers, fix an optimization that avoids updating everything on
changes to inherited links.