Drop broken special case for nested insert FOR #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some code that detects when a nested insert contains a DML inside an iterator, and explicitly reincludes it. I think that this was a workaround for when the general DML/iterator mechanisms were much more broken than they are now. It causes an extra join, and in the case of multi required things, the join is broken. Just drop that code. Fixes #3789.
elprans
approved these changes
Apr 26, 2022
msullivan
added a commit
that referenced
this pull request
Apr 26, 2022
There is some code that detects when a nested insert contains a DML inside an iterator, and explicitly reincludes it. I think that this was a workaround for when the general DML/iterator mechanisms were much more broken than they are now. It causes an extra join, and in the case of multi required things, the join is broken. Just drop that code. Fixes #3789.
|
cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some code that detects when a nested insert contains a DML
inside an iterator, and explicitly reincludes it. I think that this
was a workaround for when the general DML/iterator mechanisms were
much more broken than they are now.
It causes an extra join, and in the case of multi required things, the
join is broken. Just drop that code.
Fixes #3789.