Fix IN array_unpack for bigints #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we insert casts for the comparison operator breaks on array_unpacks. Also, we failed to take into account the scopes that we skipped over, which caused trouble in the double cast cases. Fixes #3817.
elprans
reviewed
May 3, 2022
| @@ -1389,6 +1392,11 @@ def process_set_as_membership_expr( | |||
| left_is_row_expr = astutils.is_row_expr(left_out) | |||
|
|
|||
| with newctx.subrel() as _, _.newscope() as subctx: | |||
| if is_array_unpack: | |||
| relctx.update_scope(orig_right_arg, subctx.rel, ctx=subctx) | |||
There was a problem hiding this comment.
Why do we need to update_scope on both orig_ and unwrapped_?
There was a problem hiding this comment.
Because if unwrapped_ has a path_scope_id, then that takes precedence, but otherwise we want to use orig_'s
elprans
approved these changes
May 3, 2022
|
Cherry-picked for 1.4 |
msullivan
added a commit
that referenced
this pull request
May 9, 2022
The way we insert casts for the comparison operator breaks on array_unpacks. Also, we failed to take into account the scopes that we skipped over, which caused trouble in the double cast cases. Fixes #3817.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we insert casts for the comparison operator breaks on
array_unpacks.
Also, we failed to take into account the scopes that we skipped over,
which caused trouble in the double cast cases.
Fixes #3817.