Fix generation of dummy_pathid in nonconflict ctes #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the relevant rel wasn't in the hierarchy, the search for the enclosing volatility ref wasn't succeeding, and when nonconflict CTEs were used in a for loop, sometimes things could get duplicated. (Depending on the vagaries of how pg orders the loops, I think). Fixes #3847.
elprans
approved these changes
May 10, 2022
msullivan
added a commit
that referenced
this pull request
May 10, 2022
Since the relevant rel wasn't in the hierarchy, the search for the enclosing volatility ref wasn't succeeding, and when nonconflict CTEs were used in a for loop, sometimes things could get duplicated. (Depending on the vagaries of how pg orders the loops, I think). Fixes #3847.
|
Cherry picked for 1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the relevant rel wasn't in the hierarchy, the search for the
enclosing volatility ref wasn't succeeding, and when nonconflict CTEs
were used in a for loop, sometimes things could get
duplicated. (Depending on the vagaries of how pg orders the loops, I
think).
Fixes #3847.