Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy anonymous statement #6576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop legacy anonymous statement #6576

wants to merge 1 commit into from

Commits on Dec 6, 2023

  1. Drop legacy anonymous statement

    The reason it was kept is explained in #3120, mitigated in #3814 #3837.
    But the core issue that compiler assumes mutation of transaction state
    for any compilation even by Parse message still exists. We can drop the
    `_last_anon_compiled` because the client bindings are no longer sending
    Parse + Execute for `commit` or `rollback` commands (which triggered two
    server compilation of the same command) like edgedb/edgedb-python#337.
    However, we still need to double check all bindings to make sure the
    transaction control commands are using only one `Execute` message.
    fantix committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    2b488eb View commit details
    Browse the repository at this point in the history