Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for UI #6722
base: master
Are you sure you want to change the base?
Documentation for UI #6722
Changes from all commits
6212d44
3b56556
0872b1f
5c8a323
56816d9
48b75d3
af6bc28
6830970
f21195d
8b95dad
00d0f58
6bba059
125c3c7
405fac2
227d7d5
ba655f4
89abdc6
dc5e578
26909ce
f0e4a52
00c6d66
6f8aff1
cba3f81
950e200
71c65c6
c1abca9
7986268
b5fd29c
9d4a076
b973f9a
6d62ff1
b091116
8bbaae2
f9009ae
2b92bd6
aa87adc
0b2663e
57817ef
4a423c7
e7ff59d
f16ce48
eb59c8e
d151ee1
7c4494f
242906d
59c9dd8
b502329
f4cea98
986d069
e6b19a5
ca7203d
0a27702
5c763ab
ecbc33e
bc4c6c8
957fcf6
d51279f
4c8ab19
da3ed34
461890d
d221ea8
0fd58ec
e257b9d
e62ab97
cd576d3
4229106
3529393
0d309ac
cda8a5f
624c5d5
9cbdbc6
a8167b4
569fdd0
b4ccc57
7dcf053
eb6f8e7
ea8a22b
64b21a3
2b66025
e9ae062
cb30a0c
6106d82
12a01a7
a4c63d7
6541cab
4e13fa9
83d110a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would favor putting these images before we describe the UI rather than after. I know we show the REPL example after, but the difference for me is that's an example to demonstrate what we've told you whereas these are the actual UIs we're describing. I would put this image up on line 39 so that the user can have a look before we start talking about it. I think that also makes it clearer which image is associated with which description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's the copywriter in me that generally opts for a short description followed by an image. Generally you go Product feature -> short blurb on what it's good for -> image to seal the deal. e.g. https://www.samsung.com/us/watches/galaxy-watch6/
I guess it depends on whether to generate any excitement (ooh, what does this feature look like? Ah, there's a picture) vs. more documentary feel (here's so-and-so feature, now let me tell you a bit about what you just saw)
Interesting to think about the slight difference in feel. Can definitely move the images before the description of course as it's quite a subtle difference.