Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_database_error hooks to enable testing failing restores and upgrades #7287

Merged
merged 1 commit into from
May 1, 2024

Conversation

msullivan
Copy link
Member

Add two new optional fields to the JSON object used to configure
force_database_error.

  • _scopes: Determines what operations will trigger an
    error. Defaults to ["query"]. Other checked scopes are restore
    and startup. The startup scope is only checked against
    INSTANCE configuration, not database configurations.
  • _versions: If set, only fail if the current version is present
    in the array.

… upgrades

Add two new optional fields to the JSON object used to configure
`force_database_error`.

 * `_scopes`: Determines what operations will trigger an
   error. Defaults to `["query"]`. Other checked scopes are `restore`
   and `startup`. The `startup` scope is only checked against
   `INSTANCE` configuration, not database configurations.
 * `_versions`: If set, only fail if the current version is present
   in the array.
@msullivan msullivan merged commit ccfb004 into master May 1, 2024
23 checks passed
@msullivan msullivan deleted the restore-failures branch May 1, 2024 05:45
@vpetrovykh vpetrovykh added the backported-5.x PRs that *have* been backported to 5.x (starting with 5.3) label May 2, 2024
vpetrovykh pushed a commit that referenced this pull request May 2, 2024
… upgrades (#7287)

Add two new optional fields to the JSON object used to configure
`force_database_error`.

 * `_scopes`: Determines what operations will trigger an
   error. Defaults to `["query"]`. Other checked scopes are `restore`
   and `startup`. The `startup` scope is only checked against
   `INSTANCE` configuration, not database configurations.
 * `_versions`: If set, only fail if the current version is present
   in the array.
vpetrovykh pushed a commit that referenced this pull request May 2, 2024
… upgrades (#7287)

Add two new optional fields to the JSON object used to configure
`force_database_error`.

 * `_scopes`: Determines what operations will trigger an
   error. Defaults to `["query"]`. Other checked scopes are `restore`
   and `startup`. The `startup` scope is only checked against
   `INSTANCE` configuration, not database configurations.
 * `_versions`: If set, only fail if the current version is present
   in the array.
vpetrovykh pushed a commit that referenced this pull request May 2, 2024
… upgrades (#7287)

Add two new optional fields to the JSON object used to configure
`force_database_error`.

 * `_scopes`: Determines what operations will trigger an
   error. Defaults to `["query"]`. Other checked scopes are `restore`
   and `startup`. The `startup` scope is only checked against
   `INSTANCE` configuration, not database configurations.
 * `_versions`: If set, only fail if the current version is present
   in the array.
msullivan added a commit that referenced this pull request May 10, 2024
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
msullivan added a commit that referenced this pull request May 10, 2024
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this pull request May 21, 2024
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this pull request May 22, 2024
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this pull request May 22, 2024
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this pull request May 22, 2024
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this pull request May 22, 2024
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-5.x PRs that *have* been backported to 5.x (starting with 5.3)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants