-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force_database_error hooks to enable testing failing restores and upgrades #7287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… upgrades Add two new optional fields to the JSON object used to configure `force_database_error`. * `_scopes`: Determines what operations will trigger an error. Defaults to `["query"]`. Other checked scopes are `restore` and `startup`. The `startup` scope is only checked against `INSTANCE` configuration, not database configurations. * `_versions`: If set, only fail if the current version is present in the array.
elprans
approved these changes
May 1, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 2, 2024
… upgrades (#7287) Add two new optional fields to the JSON object used to configure `force_database_error`. * `_scopes`: Determines what operations will trigger an error. Defaults to `["query"]`. Other checked scopes are `restore` and `startup`. The `startup` scope is only checked against `INSTANCE` configuration, not database configurations. * `_versions`: If set, only fail if the current version is present in the array.
vpetrovykh
pushed a commit
that referenced
this pull request
May 2, 2024
… upgrades (#7287) Add two new optional fields to the JSON object used to configure `force_database_error`. * `_scopes`: Determines what operations will trigger an error. Defaults to `["query"]`. Other checked scopes are `restore` and `startup`. The `startup` scope is only checked against `INSTANCE` configuration, not database configurations. * `_versions`: If set, only fail if the current version is present in the array.
vpetrovykh
pushed a commit
that referenced
this pull request
May 2, 2024
… upgrades (#7287) Add two new optional fields to the JSON object used to configure `force_database_error`. * `_scopes`: Determines what operations will trigger an error. Defaults to `["query"]`. Other checked scopes are `restore` and `startup`. The `startup` scope is only checked against `INSTANCE` configuration, not database configurations. * `_versions`: If set, only fail if the current version is present in the array.
msullivan
added a commit
that referenced
this pull request
May 10, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 21, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new optional fields to the JSON object used to configure
force_database_error
._scopes
: Determines what operations will trigger anerror. Defaults to
["query"]
. Other checked scopes arerestore
and
startup
. Thestartup
scope is only checked againstINSTANCE
configuration, not database configurations._versions
: If set, only fail if the current version is presentin the array.