fix: Set logger in MqttFactory to avoid panic when AuthMode is empty #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
force-pushed
the
mqtt-factory-panic-fix
branch
from
d7d9739
to
41e3612
Compare
closes edgexfoundry#920 Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
mqtt-factory-panic-fix
branch
from
41e3612
to
306d196
Compare
jim-wang-intel
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
MqttFactory will panic when attempt to log warning about
authModeempty du to logger not set in the factory method.Issue Number: #920
What is the new behavior?
Logger set set in the factory method avoiding panic and logging wanring.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information