Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Add operatingState and adminState to service object #207

Merged
merged 1 commit into from
May 3, 2019
Merged

Add operatingState and adminState to service object #207

merged 1 commit into from
May 3, 2019

Conversation

cherrycl
Copy link
Contributor

Signed-off-by: Cherry Wang cherry@iotechsys.com

fix #205

@tsconn23
Copy link
Member

FYI -- During testing of the core-metadata/device tests the following validation error occurred.

Test PUT 59 http://localhost:48081/api/v1/device
Request body { "id":"57f63243e4b060e2e0dd6ed0", "name": "livingroomthermostatdevice", "description":"Home automation", "adminstate":"LOCKED" }
Response body no supporting protocol specified for device

This indicates the required protocols for the device have not been specified
https://github.com/edgexfoundry/go-mod-core-contracts/blob/f8b9cd6695633badbdfef91e1ad891eac7132b1e/models/device.go#L139

@tsconn23
Copy link
Member

Also, I'm having an issue with the core-command-importer collection. It's not actually populating anything in the database. When I look at the core service logging with LogLevel=TRACE, all I see is the ping endpoint getting called four times. I have attached an exported result set from Postman that shows this.

I realize this is different than the issue this PR is targeted at, but it does make the PR hard to approve since the collection doesn't appear to be acting as it's supposed to. Please correct me if I'm misinterpreting these results.

core-command-importer.postman_test_run.txt

@cherrycl
Copy link
Contributor Author

@tsconn23 I fixed the device issue. Please help to verify it again.
For the core-command importer, I found you run the file by 48082 port.
Actually, all of requests in core-command importer are core-metadata API, so you have to use 48081 port.

tsconn23
tsconn23 previously approved these changes May 3, 2019
Copy link
Member

@tsconn23 tsconn23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase. LGTM.

Signed-off-by: Cherry Wang <cherry@iotechsys.com>
@tsconn23 tsconn23 merged commit 711a695 into edgexfoundry:master May 3, 2019
@cherrycl cherrycl deleted the issue-205 branch October 16, 2019 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interlock -- Model Validation Requires Request Integrity
2 participants