This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
refactor: Update to assign and uses new Port Assignments #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #160 BREAKING CHANGE: Device Modbus default port number has changed to 59988 Signed-off-by: lenny <leonard.goodell@intel.com>
|
recheck |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-random/blob/master/.github/CONTRIBUTING.md
What is the current behavior?
Ports assigned for Core/Supporting services are 408xx range
Device Random uses 49988
Issue Number: #160
What is the new behavior?
Ports assigned for Core/Supporting services are 598xx range
Device Random now uses 59988
Also removed duplicate MQTT MessageBus configuration
Does this PR introduce a breaking change?
BREAKING CHANGE: Device Modbus default port number has changed to 59988
New Imports
Specific Instructions
Other information