This repository has been archived by the owner on Jan 8, 2021. It is now read-only.
internal/secure/config.go: specify 10 retry attempts @ 1 Hz (master) #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymouse64
changed the title
|
@anonymouse64 Needs a rebase |
This will fix the race condition we currently have when security-secretstore-setup is run at the same time as docker-edgex-mongo and the secrets haven't been put into vault yet and currently docker-edgex-mongo immediately fails when vault returns a 404 for the secret. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
…files This lets a user configure retry attempts getting secrets from Vault. Also update the version of go-mod-secrets to allow setting these properties in the SecretConfig. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
…tConfig This is in concert with a change in go-mod-secrets where the time parsing is done there and all clients of go-mod-secrets can just provide a string without concerning much with the internal details of how that is parsed. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
bugfix/getsecrets-loop
branch
from
c7dd022
to
0515854
Compare
|
@lranjbar done rebased |
lranjbar
approved these changes
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #59 and #67 combined into one PR for master/Geneva.