Skip to content
This repository has been archived by the owner on Jan 8, 2021. It is now read-only.

Update build to Geneva pipeline #76

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

lranjbar
Copy link

@lranjbar lranjbar commented Jan 6, 2020

I'm able to build an arm64 image locally using the same Dockerfile. We will need to test on the EdgeX Jenkins server once it is back up again.

Signed-off-by: Lisa Rashidi-Ranjbar lisa.a.rashidi-ranjbar@intel.com

@lranjbar lranjbar added the geneva label Jan 6, 2020
@lranjbar lranjbar self-assigned this Jan 6, 2020
@lranjbar lranjbar added this to QA/Code Review in DevOps WG via automation Jan 6, 2020
Copy link
Contributor

@soda480 soda480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we build arm64 using Sandbox?

Signed-off-by: Lisa Rashidi-Ranjbar <lisa.a.rashidi-ranjbar@intel.com>
@lranjbar
Copy link
Author

lranjbar commented Jan 7, 2020

@difince @cloudxxx8 We are able to build the arm64 images using the same Dockerfile in the CI infrastructure. This is because mongo has released arm64 images under the same tag. We can now remove the duplication for the two Dockerfiles.

See the logs of the last shell script here:
https://jenkins.edgexfoundry.org/blue/organizations/jenkins/edgexfoundry%2Fdocker-edgex-mongo/detail/PR-76/1/pipeline/132

Copy link
Contributor

@difince difince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lranjbar I am glad to hear we do not need anymore two diff docker files. I could test it by myself tomorrow

@lranjbar
Copy link
Author

lranjbar commented Jan 8, 2020

@difince Please let me know if you can build locally using the same Dockerfile. I'd like to close this one out this week. Thanks

Copy link

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Lisa!

@lranjbar lranjbar merged commit 15d83ac into edgexfoundry:master Jan 13, 2020
DevOps WG automation moved this from QA/Code Review to Done Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
DevOps WG
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants