Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adr): updated 0002 to remove change in V2 API that was overruled #335

Closed
wants to merge 1 commit into from

Conversation

jpwhitemn
Copy link
Member

Removed the implementation for v2 API changes on array of strings and non-array types that was overruled by architects meeting in January.

Decision was made to keep implementation as it is in v1

Signed-off-by: Jim White jpwhite_mn@yahoo.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/master/.github/Contributing.md.

What is the current behavior?

n/a

Issue Number:

none

What is the new behavior?

n/a

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Change to ADR 0002 to address decision (reversal) on array types in readings per Architect's meeting of Jan 26th 2021.

Removed the implementation for v2 API changes on array of strings and non-array types that was overruled by architects meeting in January.

Decision was made to keep implementation as it is in v1

Signed-off-by: Jim White <jpwhite_mn@yahoo.com>
@jpwhitemn jpwhitemn added ADR Architecture Decision Record documentation ireland 1-low priority denoting isolated changes labels Feb 3, 2021
@jpwhitemn jpwhitemn changed the title fix(adr):updated 0002 to remove change in V2 API that was overruled fix(adr): updated 0002 to remove change in V2 API that was overruled Feb 3, 2021
@jpwhitemn
Copy link
Member Author

recheck

@jpwhitemn jpwhitemn closed this Feb 3, 2021
@jpwhitemn jpwhitemn deleted the adr-0002-upd branch February 3, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-low priority denoting isolated changes ADR Architecture Decision Record documentation ireland
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant