Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Addressed permission error in redis v7 #4027 #4118

Merged
merged 2 commits into from
Aug 4, 2022
Merged

fix: Addressed permission error in redis v7 #4027 #4118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8628ecf
fix: Addressed permission error in redis v7 #4027
Aug 4, 2022
af2cb54
fix: Updated permission #4027
Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/security/bootstrapper/helper/redis_conf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const (
aclFileConfigTemplate = "aclfile {{.ACLFilePath}}"

// aclDefaultUserTemplate is the ACL rule for "default" user
aclDefaultUserTemplate = "user {{.RedisUser}} on allkeys +@all -@dangerous #{{.Sha256RedisPwd}}"
aclDefaultUserTemplate = "user {{.RedisUser}} on allkeys allchannels +@all -@dangerous #{{.Sha256RedisPwd}}"
)

// GenerateRedisConfig writes the startup configuration of Redis server based on pre-defined template
Expand Down
4 changes: 2 additions & 2 deletions internal/security/bootstrapper/helper/redis_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ func TestGenerateACLConfig(t *testing.T) {
}

require.Equal(t, 1, len(outputlines))
require.Equal(t, fmt.Sprintf("user default on allkeys +@all -@dangerous #%x",
require.Equal(t, fmt.Sprintf("user default on allkeys allchannels +@all -@dangerous #%x",
sha256.Sum256([]byte(testFakePwd))), outputlines[0])
// should not be equal if use different password
require.NotEqual(t, fmt.Sprintf("user default on allkeys +@all -@dangerous #%x",
require.NotEqual(t, fmt.Sprintf("user default on allkeys allchannels +@all -@dangerous #%x",
sha256.Sum256([]byte("differentPassword"))), outputlines[0])
}