Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): Create CORS related config struct #286

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Oct 15, 2021

Create CORS related configuration struct in ServiceInfo to
allow each microservice enable CORS via configuration.

Signed-off-by: Cloud Tsai cloudxxx8@gmail.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) create struct only, not function
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) create struct only, not function
  • I have opened a PR for the related docs change (if not, why?) docs issue opened Create document to instruct the CORS settings edgex-docs#608

Testing Instructions

N/A

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #286 (27f0cab) into main (d015cf1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   57.74%   57.74%           
=======================================
  Files          13       13           
  Lines         897      897           
=======================================
  Hits          518      518           
  Misses        358      358           
  Partials       21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d015cf1...27f0cab. Read the comment docs.

Create CORS related configuration struct in ServiceInfo to
allow each microservice enable CORS via configuration.

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 4ec4738 into edgexfoundry:main Oct 18, 2021
@cloudxxx8 cloudxxx8 deleted the issue-281 branch October 20, 2021 13:45
judehung pushed a commit to IOTechSystems/go-mod-bootstrap that referenced this pull request Nov 15, 2021
Create CORS related configuration struct in ServiceInfo to
allow each microservice enable CORS via configuration.

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants