This repository has been archived by the owner on Jan 10, 2020. It is now read-only.
Fixes for Issue 37 40 41 42. Port changes from Delhi to master. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Add log level argument to NewClient
Signed-off-by: Tingyu Zeng <tingyu.zeng@rsa.com>
* Use Form for uploading certificates due to bug with kong 0.13.x where the snis parameter is ignored when using JSON * Load certificates into kong first, before adding any services or routes * Use single loop to create service and associated routes so that we can use the service ID returned from kong when creating the service when creating the route * Add Service parameter to KongRoute struct * Use JSON for creating a kong route * initKongService returns a KongServiceResponse object now for extracting the ID from the created service Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Jeremy Phelps <jphelps@linuxfoundation.org>
…o-kong-token Use certificates from vault for kong routes
Use long sha for container label
Signed-off-by: Tingyu Zeng <tingyu.zeng@rsa.com>
…already-initialized Skip the steps if the services and routes are initialized already.
Signed-off-by: Tingyu Zeng <tingyu.zeng@rsa.com>
…ersion-delhi Update the version to delhi.
0.2.0 is tagged and released. Signed-off-by: Jeremy Phelps <jphelps@linuxfoundation.org>
tingyuz
force-pushed
the
issue-37-40-41-42
branch
from
74ca868
to
3b80267
Compare
|
recheck. |
jpwhitemn
reviewed
Dec 12, 2018
anonymouse64
suggested changes
Dec 12, 2018
glide.yaml
Outdated
| @@ -7,5 +7,6 @@ import: | |||
| - package: github.com/dgrijalva/jwt-go | |||
| version: v3.2.0 | |||
| - package: github.com/edgexfoundry/edgex-go | |||
| version: delhi | |||
There was a problem hiding this comment.
This line still needs be changed to master as this PR is targeting master...
There was a problem hiding this comment.
addressed in this PR with another push.
Signed-off-by: Tingyu Zeng <tingyu.zeng@rsa.com>
tingyuz
force-pushed
the
issue-37-40-41-42
branch
from
3b80267
to
ee15c1c
Compare
Signed-off-by: Tingyu Zeng <tingyu.zeng@rsa.com>
|
LGTM, thanks for changing the glide version |
anonymouse64
approved these changes
Jan 2, 2019
jpwhitemn
approved these changes
Jan 3, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.