Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Incident Report for 2019-02-20 Versionista Scraper Silent Failure #17

Merged

Conversation

Mr0grog
Copy link
Member

@Mr0grog Mr0grog commented Feb 25, 2019

Versionista imports started silently failing on 2019-02-12 and we didn't detect it until a user reported some unusual logs a week later.

The fix for this lives in edgi-govdata-archiving/web-monitoring-versionista-scraper#196, which has not yet been reviewed and merged, but is currently running in production.

Versionista imports started silently failing on 2019-02-12 and we didn't detect it until a user reported some unusual logs a week later.
### What Went Wrong

- This didn’t register as an actual error and we had no alerts about it for a week.
- Other people saw the issue before @Mr0grog but did not respond or investigate or flag it for someone who could.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who (besides @jjudish) saw this before you? Was this an analyst/dev communication gap?

Copy link
Member Author

@Mr0grog Mr0grog Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know at least @lightandluck did, because the reason I saw the issue as early as I did was his comment on Slack. But he did not note that there was a potential major data problem: https://archivers.slack.com/archives/C47DJK8H0/p1550710886000900

(That’s actually why the first second entry in the timeline is me replying to the issue from my phone and noting I’d take a look when I got to a computer.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, sorry, I really didn't understand how big of a problem it was! I assumed it was just a problem on their end because I thought we had things covered by Sentry. I didn't think troubleshooting someone else's instance would be urgent. But know now that if someone is having problems with our software, we might have the same problem! Will remember in the future.

(Really I was dumbstruck by the fact that someone else was using the scraper for a year and we had never heard anything from them. But finding out it was WIP was anti-climatic)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, this makes me really want to go read all the other incident reports. Good lesson learned. Thanks y'all for your diligence 👍 💯 💪

### What Went Wrong

- This didn’t register as an actual error and we had no alerts about it for a week.
- Other people saw the issue before @Mr0grog but did not respond or investigate or flag it for someone who could.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context!

@jsnshrmn jsnshrmn merged commit 87eac26 into master Feb 27, 2019
@jsnshrmn jsnshrmn deleted the incident-2019-02-20--versionista-scraper-silent-failure branch February 27, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants