Add *MAX-LINE-LENGTH* and *MAX-HEADER-LINE-LENGTH* #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
requested changes
Jan 10, 2022
| @@ -100,8 +100,11 @@ Additionally logs this string to LOG-STREAM if it is not NIL." | |||
| (let ((result | |||
| (with-output-to-string (line) | |||
| (loop for char-seen-p = nil then t | |||
| for count from 0 | |||
| for char = (read-char* stream nil) | ||
| for is-cr-p = (and char (char= char #\Return)) | ||
| when (and *max-line-length* (> count *max-line-length*)) | ||
| do (error 'input-exceeded-limit :maximum *max-line-length*) |
| @@ -78,6 +78,13 @@ variable has a true value, though.") | |||
| "A `buffer' for one character. Used by PEEK-CHAR* and | |||
| UNREAD-CHAR*.") | |||
|
|
|||
| (defvar *max-line-length* nil | |||
| "Maximum length of a line. If NIL, lines may be any length.") | |||
There was a problem hiding this comment.
I'd appreciate more documentation. The docstring should address:
- what happens when attempting to read an overlong line.
- appropriate types and values this variable may take
| @@ -78,6 +78,13 @@ variable has a true value, though.") | |||
| "A `buffer' for one character. Used by PEEK-CHAR* and | |||
| UNREAD-CHAR*.") | |||
|
|
|||
| (defvar *max-line-length* nil | |||
There was a problem hiding this comment.
Please add declaim of type for this and the other special var. I assume the correct type is (or null unsigned-byte), but it may be (or null (and fixnum unsigned-byte)) or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8.
This adds two special variables and an error condition.