Use Task.Run to start OperationQueue. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
added a commit
to github/VisualStudio
that referenced
this pull request
May 15, 2018
To incorporate editor-tools/Akavache#1 Fixes #1662.
Use `Task.Run` to start `OperationQueue`'s processing task rather than using the constructor and then calling `task.Start`. This ensures two things: 1. The `TaskScheduler.Default` scheduler is used, which will be a threadpool scheduler 2. That `task` tracks the running of the entire task: previously the task will have completed when it `await`ed as the `Task` constructor accepts an `Action` and not a `Func<Task>` Fixes reactiveui#406
grokys
force-pushed
the
fixes/1662-task-startnew
branch
from
4f8bf07
to
dcd51f7
Compare
grokys
changed the title
grokys
added a commit
to github/VisualStudio
that referenced
this pull request
May 16, 2018
Beacuse editor-tools/Akavache#1 was updated to cherry pick reactiveui/Akavache#407.
jcansdale
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of reactiveui#407 targetting
GHfVSbranch.