Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Task.Run to start OperationQueue. #1

Merged
merged 1 commit into from May 16, 2018
Merged

Use Task.Run to start OperationQueue. #1

merged 1 commit into from May 16, 2018

Commits on May 16, 2018

  1. fix: Use Task.Run to start OperationQueue. 

    Use `Task.Run` to start `OperationQueue`'s processing task rather than using
the constructor and then calling `task.Start`. This ensures two things:

1. The `TaskScheduler.Default` scheduler is used, which will be a threadpool
scheduler
2. That `task` tracks the running of the entire task: previously the task
will have completed when it `await`ed as the `Task` constructor accepts an
`Action` and not a `Func<Task>`

Fixes reactiveui#406
    @grokys
    grokys committed May 16, 2018
    Copy the full SHA
    dcd51f7 View commit details
    Browse the repository at this point in the history