Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image outputs blank version #166

Closed
polarathene opened this issue Jun 4, 2021 · 3 comments · Fixed by #168 or #173
Closed

Docker image outputs blank version #166

polarathene opened this issue Jun 4, 2021 · 3 comments · Fixed by #168 or #173
Labels
bug a bug which occured docs issues regarding documentation good first issue

Comments

@polarathene
Copy link
Contributor

polarathene commented Jun 4, 2021

docker run --rm -it mstruebing/editorconfig-checker:2.3.5 ec -version outputs nothing. I've also run the ec -version command via the containers shell internally and got the same result. Commands like ec -help work correctly.

This is an issue as even though the config specifies 2.3.5 in it's "Version" property, the tool exits stating versions do not match. I have seen in the source (which has some grammar and spelling errors in comment):

// version is used vor the help
// version is dynamically set at compiletime
var version string

Is that meant to be set in the Dockerfile?


Additionally, in the README, you have two example configs, one matches the source with PascalCase, while the other is in snake_case. Did that convention change at some point and the snake_case example was not updated? Or are both styles supported? (not clarified in the README)

@mstruebing mstruebing added bug a bug which occured docs issues regarding documentation good first issue labels Jun 4, 2021
@mstruebing
Copy link
Member

Thank you, I will have a look at the version issue.

In regard to the documentation, I think that changed at some point, the snake_case should not work if I have everything in mind correctly.

However, feel free to provide a pull request regarding changes 👍

@mstruebing
Copy link
Member

Documentation is fixed, docker image isn't.

@mstruebing
Copy link
Member

$ docker run -it mstruebing/editorconfig-checker:latest /usr/bin/ec --version
Unable to find image 'mstruebing/editorconfig-checker:latest' locally
latest: Pulling from mstruebing/editorconfig-checker
540db60ca938: Already exists
5fe8a97609e0: Pull complete
ea0b182ef113: Pull complete
835b52ff4d35: Pull complete
Digest: sha256:debbffc2d58536d50231dde9d62468f37d32433fd59b410eacee0a8600ec2109
Status: Downloaded newer image for mstruebing/editorconfig-checker:latest
2.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug which occured docs issues regarding documentation good first issue
Projects
None yet
2 participants