Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix config example + note on regex use #168

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

polarathene
Copy link
Contributor

@polarathene polarathene commented Jun 4, 2021

As a new user, an outdated config example and lack of clarification on filepaths for regex matching on tripped me up. Updated the README as requested to help others avoid those problems.

Fixes: #166
Fixes: #167

(Technically doesn't fix #166 , that still needs to build with the version included correctly into the Docker image. Resolves the other concern about documentation that was discussed)

Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 🙏

@mstruebing mstruebing merged commit 905569d into editorconfig-checker:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document exclude regex is on relative path Docker image outputs blank version
2 participants