Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not passing -vsver to subsequent calls of build.ps1 #95

Closed
Manuzor opened this issue Apr 17, 2023 · 0 comments · Fixed by #96
Closed

Not passing -vsver to subsequent calls of build.ps1 #95

Manuzor opened this issue Apr 17, 2023 · 0 comments · Fixed by #96

Comments

@Manuzor
Copy link
Contributor

Manuzor commented Apr 17, 2023

Trying to build this from source on windows for the first time I hit an error that Visual Studio 15 2017 is not installed. Which is true because I only have Visual Studio 17 2022 installed.

I believe the following two lines are missing the argument -vsver $vsver.

editorconfig-core-c/build.ps1

Lines 51 to 52 in aa6b3ed

.\build.ps1 -proj pcre2 -init:$init -install:$install -arch $arch -config $config -static $static
.\build.ps1 -proj core -init:$init -install:$install -arch $arch -config $config -static $static

Manuzor added a commit to Manuzor/editorconfig-core-c that referenced this issue Apr 17, 2023
@Manuzor
Pass $vsver to subsequent calls of build.ps1
615de76 
Fixes editorconfig#95
Manuzor added a commit to Manuzor/editorconfig-core-c that referenced this issue Apr 17, 2023
@Manuzor
Pass $vsver to subsequent calls of build.ps1
bd41ae2 
Fixes editorconfig#95
@Manuzor Manuzor mentioned this issue Apr 17, 2023
Merged
xuhdev pushed a commit that referenced this issue Apr 23, 2023
@Manuzor
Pass $vsver to subsequent calls of build.ps1 (#96)
f2a2b49 
Fixes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass $vsver to subsequent calls of build.ps1 Manuzor/editorconfig-core-c
1 participant
@Manuzor