Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in editorconfig_parse() #76

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Fix memory leak in editorconfig_parse() #76

merged 1 commit into from
Jun 17, 2021

Conversation

siegel
Copy link
Contributor

@siegel siegel commented Jun 8, 2021 •
edited by xuhdev

Close #75.

@siegel
* Fix memory leak in editorconfig_parse() which would occur if no
05943e8 
	`.editorconfig` files were found in the file's ancestry or if an
	error occurred while ingesting values.
xuhdev
xuhdev approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice catch. The memory-related logic in editorconfig_parse should probably be cleaned up in the future :)

@xuhdev xuhdev merged commit 082268b into editorconfig:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuhdev xuhdev xuhdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editorconfig_parse() leaks memory when no .editorconfig files are found or there are no values
2 participants
@siegel @xuhdev