Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape real paths for use in minimatch #108

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Conversation

hildjj
Copy link
Collaborator

@hildjj hildjj commented Oct 10, 2022

Fixes #86.

Can someone check my understanding of what characters minimatch thinks are "special"? If nobody else gets to it, I'll look at the source tomorrow. Here is the list I've currently got:

|*!+#?{}()[\]]

@hildjj
Copy link
Collaborator Author

hildjj commented Oct 11, 2022

@ is also special, and # is treated differently than the others.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3229480927

  • 0 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 99.396%

Totals Coverage Status
Change from base Build 3222275643: 0.2%
Covered Lines: 396
Relevant Lines: 396

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3229480927

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 99.396%

Totals Coverage Status
Change from base Build 3222275643: 0.2%
Covered Lines: 396
Relevant Lines: 396

💛 - Coveralls

@hildjj hildjj merged commit 0a5a422 into editorconfig:master Oct 11, 2022
@hildjj hildjj deleted the escape branch October 13, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken resolution for paths that include [ characters
2 participants