Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of GeanyFunctions, fix deprecated warning #15

Merged
merged 1 commit into from Jul 26, 2019
Merged

remove use of GeanyFunctions, fix deprecated warning #15

merged 1 commit into from Jul 26, 2019

Conversation

andy5995
Copy link
Contributor

This fixes the compiler warning about the deprecated GeanyFunctions
https://github.com/geany/geany/blob/9c91c287803ae05ce0f2aacd605564301e0ef4aa/src/plugindata.h#L408)

@xuhdev
Copy link
Member

xuhdev commented Jul 26, 2019

Do you have idea whether there needs a replacement?

@andy5995
Copy link
Contributor Author

Pretty sure it doesn't. Here's what @elextr one of the @geany maintainers said about it...

it can't be removed if something used it

When I remove that line, editorconfig still builds, and is available from the Geany plugins manager. I tested it to make sure.

@xuhdev
Copy link
Member

xuhdev commented Jul 26, 2019

According to geany/geany-plugins#382 , it seems like we also need to bump API version if we are to remove GeanyFunctions, so as to prevent users on older geany from building.

@elextr
Copy link

elextr commented Jul 26, 2019

@andy5995 I was actually talking about Geany code in the quote you taketh in vain. :)

But it does indeed also apply correctly to the plugin too, if nothing in the plugin uses that variable, why declare it :)

@xuhdev this is to remove it from the plugin, not from Geany.

@xuhdev xuhdev merged commit cc02b9d into editorconfig:master Jul 26, 2019
@xuhdev
Copy link
Member

xuhdev commented Jul 26, 2019

Thanks all!

@andy5995 andy5995 deleted the fix_deprecated branch November 28, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants