Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeanyFunctions depreciation warnings #382

Closed
techee opened this issue Mar 5, 2016 · 3 comments · Fixed by #388
Closed

GeanyFunctions depreciation warnings #382

techee opened this issue Mar 5, 2016 · 3 comments · Fixed by #388
Milestone

Comments

@techee
Copy link
Member

techee commented Mar 5, 2016

Most of the plugins now complain about GeanyFunctions being deprecated which makes the compilation output rather noisy. I have removed GeanyFunctions from my plugins but this requires bumping API to a post-linkage-cleanup build, which is 224.

To get rid of the warnings there are two options:

  1. Remove geany_functions and bump the API requirement for every plugin.
  2. Guard the geany_functions declaration with a macro checking the API version.

I'd personally vote for (1) otherwise the deprecated declaration gets never removed. Is it a problem to bump the API requirement? Is it common to build new plugin versions with old Geany versions?

@eht16
Copy link
Member

eht16 commented Mar 6, 2016

I'd also agree for (1).

I've just done this for the Addons and SpellCheck plugins.

Keeping compability with old Geany versions is a nice-to-have I'd say but not really necessary as we try to release Geany-Plugins together with Geany itself. So this should be fine.

@b4n
Copy link
Member

b4n commented Mar 6, 2016

Agreed, we should rather drop them. And as it's already in 1.26 even.

@techee
Copy link
Member Author

techee commented Mar 6, 2016

Good, will prepare a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants