Add elementary Code #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@treyhunner Please review 🙇 |
|
@Pittan works for us! Thank you so much! |
|
@xuhdev Please review and merge 🙇 |
treyhunner
approved these changes
Apr 29, 2018
xuhdev
requested changes
Apr 30, 2018
index.html
Outdated
| @@ -125,6 +125,7 @@ <h2>No Plugin Necessary</h2> | |||
| <ul class="editor-logos"> | |||
| <li><a href="http://barebones.com/support/technotes/editorconfig.html"><img src="logos/bbedit.png" alt="BBEdit"><span>BBEdit</span></a></li> | |||
| <li><a href="https://github.com/eranif/codelite/tree/master/EditorConfigPlugin"><img src="logos/codelite.png" alt="CodeLite"><span>CodeLite</span></a></li> | |||
| <li><a href="https://github.com/elementary/code"><img src="logos/elementary-code.png" alt="elementary Code"><span>elementary Code</span></a></li> | |||
There was a problem hiding this comment.
Does it have an individual page? I couldn't find it but it seems like there should be one. If not, can you change the link to https://github.com/elementary/code#readme?
There was a problem hiding this comment.
@cassidyjames Does it have an individual page?
@xuhdev I changed the link. If it doesn't have a page, please merge it 🙇
|
@Pittan the editorconfig implementation is available at https://github.com/elementary/code/tree/master/plugins/editorconfig, but there's not a specific landing page for it or anything. |
xuhdev
approved these changes
Apr 30, 2018
|
Cool, thanks! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86