-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elementary Code #88
Conversation
@treyhunner Please review 🙇 |
@Pittan works for us! Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to @elementary 😀
@xuhdev Please review and merge 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks! Just a minor comment.
index.html
Outdated
@@ -125,6 +125,7 @@ <h2>No Plugin Necessary</h2> | |||
<ul class="editor-logos"> | |||
<li><a href="http://barebones.com/support/technotes/editorconfig.html"><img src="logos/bbedit.png" alt="BBEdit"><span>BBEdit</span></a></li> | |||
<li><a href="https://github.com/eranif/codelite/tree/master/EditorConfigPlugin"><img src="logos/codelite.png" alt="CodeLite"><span>CodeLite</span></a></li> | |||
<li><a href="https://github.com/elementary/code"><img src="logos/elementary-code.png" alt="elementary Code"><span>elementary Code</span></a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have an individual page? I couldn't find it but it seems like there should be one. If not, can you change the link to https://github.com/elementary/code#readme
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cassidyjames Does it have an individual page?
@xuhdev I changed the link. If it doesn't have a page, please merge it 🙇
@Pittan the editorconfig implementation is available at https://github.com/elementary/code/tree/master/plugins/editorconfig, but there's not a specific landing page for it or anything. |
Cool, thanks! 🎆 |
Closes #86