Update it #386
Closed
Update it #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the device (lisa) to Actions
Corrected the Device Name
|
Edk2 main branch is known to introduce breaking changes often breaking the build process. As a result if you drop the last commit here you may one day make builds fail due to an update on their end. I think it would be better to set the last known good commit sha1 instead of removing it all together. Even if you can rely on git submodule functionality it at least documents nicely the commit intended to work |
|
@ETCHDEV whats the point of this PR? I have not gotten an answer on this and it looks like you made a change 2 days ago. Should we close this? You do not seem open to discussing #386 (comment) or make changes |
|
Sorry for late reply, but ya I am closing the commit has this commit does nothing |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Description of the changes you are submitting]
Checklist