Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FND-380a - Revise / replace several ontologies with their counterparts from the Commons Ontology Library v1.1 #1995

Merged
merged 17 commits into from
Jan 29, 2024

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented Jan 19, 2024

Description

  1. Replace / deprecate elements in FIBO with their equivalents from the Commons 1.1 Roles and Compositions ontology
  2. Replace / deprecate elements in FIBO with their equivalents from the Commons 1.1 Parties and Situations ontology
  3. Replace uses of hasIdentity in Relations with its equivalent in the Commons 1.1 Roles and Compositions ontology

Fixes: #1994 / FND-380

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

…with their equivalents from the Commons 1.1 ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…th their equivalent from the Commons 1.1 ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…tology with those from the corresponding Commons 1.1 ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…h their equivalents from the Commons 1.1 ontologies in additional FIBO ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…h their equivalents in the Commons 1.1 ontologies and eliminated unused declarations for the roles ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…roles with their counterparts in the Commons 1.1 and eliminate unused references to the roles ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…nse to reuse other elements from Commons 1.1 instead of what was in FIBO

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…ences to the FND roles ontology, allowing the entire ontology to be deprecated for elimination in a subsequent release

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
… from the Parties ontology with those in the equivalent Commons 1.1 library ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
… and replaced them with their counterpartis from the Commons 1.1 ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…IBO ontologies that are now available in the Commons 1.1 ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…ties in the Occurrences ontology, moved exemplifies and isExemplifiedBy to Relations for wider use in place of realizes / isRealizedBy to avoid name collisions with the Commons 1.1 Parties and Situations ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…property from the Parties ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…ents and commitments as states of affairs

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added enhancement consistency About overall consistency FND FIBO Foundations Commons Domain labels Jan 19, 2024
@ElisaKendall ElisaKendall self-assigned this Jan 19, 2024
… FND relations with its equivalent in the Commons 1.1 Ontology Library

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…with the equivalent from the Commons 1.1 ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall changed the title FND-380a - Revise / replace several ontologies with their counterparts from the Commons Ontology Library v1.1 (WIP) FND-380a - Revise / replace several ontologies with their counterparts from the Commons Ontology Library v1.1 Jan 23, 2024
Copy link
Contributor

@rivettp rivettp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An Organization should not be a subclass of/treated as a collection.
That's why I'm concerned with the PR proposing to use hasMember/isMemberOf, from Collections which in Commons has the note:

            skos:noteNote that the domain of hasMember should be some sort of collection, aggregate, or group. In the Financial Industry Business Ontology (FIBO), hasMember is used in the case of parties (people and organizations), whereas comprises can have anything in its range.</skos:note>

Here the English language is working against us: despite both using "member", membership of an organization is quite different semantically from membership of a collection.
Bottom line, I feel it's wrong to use Collections for organizations.

@ElisaKendall
Copy link
Contributor Author

An Organization should not be a subclass of/treated as a collection. That's why I'm concerned with the PR proposing to use hasMember/isMemberOf, from Collections which in Commons has the note:

            skos:noteNote that the domain of hasMember should be some sort of collection, aggregate, or group. In the Financial Industry Business Ontology (FIBO), hasMember is used in the case of parties (people and organizations), whereas comprises can have anything in its range.</skos:note>

Here the English language is working against us: despite both using "member", membership of an organization is quite different semantically from membership of a collection. Bottom line, I feel it's wrong to use Collections for organizations.

The use of this property has been in the ontology for years - we revised it to use the property from Commons last year, replacing the one from Relations, but the use of that specific property has been in the ontology for a long time. Fixing it, if we decide to do so, should be done in the context of a new issue, not in this one.

@jfgemski
Copy link

I agree with Pete.

@ElisaKendall
Copy link
Contributor Author

ElisaKendall commented Jan 25, 2024

I agree with Pete.

This doesn't make sense to me - after further review, the definition of hasMember is "includes, as a discrete element" which is true of the members of any team, including an organization. The note that says "Note that the domain of hasMember should be some sort of collection, aggregate, or group." includes a second sentence, which is "In the Financial Industry Business Ontology (FIBO), hasMember is used in the case of parties (people and organizations), whereas comprises can have anything in its range." This is precisely the case with respect to the use of hasMember on the Organization class. An organization is an aggregate. It is not a collection in the sense of a set, but it does have people that are part of the organization.

The change impacts not only the Organization class, but all of its subclasses as well as other classes that include related concepts. Rather than doing this, I would prefer to raise an issue in Commons to remove the note about the domain. Use of this property was not part of the pull request - the change to the organization class was to change the now deprecated IndependentParty from FIBO to Party from Commons. This change would impact roughly 20 odd ontologies in FIBO plus reference data. Every place we use isMemberOf or hasMember has to be reviewed individually and others would need revision as well. That includes more than 3000 individuals, only some of which should be changed, if we agree to make this change, based on a cursory review.

I think this should be discussed in a separate issue, and we should include Davide, who can help explain why or why not the approach taken in the Organizations ontology in FIBO is correct with respect to its definition in Commons before we make a wholesale change in the semantics like this.

@jfgemski
Copy link

Changed my mind after reading the definition we have plus the dictionary definition. Pete is correct that the meaning is different in the business world. The problem I have is what is a business organization a collection of? Is it a collection of employees, a collection of shareholders, etc.? Let's discuss at our next meeting.

@tahoeblue
Copy link

tahoeblue commented Jan 25, 2024 via email

@ElisaKendall
Copy link
Contributor Author

I also agree (with Pete and John). A single organization is a single thing (with a single persona). It would have a single LEI, for example. One can talk about the internal structures of an organization as a set of business units, or people, or locations, etc, but the organization itself is not a collection of similar things in a set or list — it is a unique thing.

-Jeff
On Jan 24, 2024, at 5:09 PM, John Gemski @.***> wrote: Changed my mind after reading the definition we have plus the dictionary definition. Pete is correct that the meaning is different in the business world. The problem I have is what is a business organization a collection of? Is it a collection of employees, a collection of shareholders, etc.? Let's discuss at our next meeting. — Reply to this email directly, view it on GitHub <#1995 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB72TFTBB2FNK577FDUZHFLYQGWELAVCNFSM6AAAAABCCME7D2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGE4DCMJYGM. You are receiving this because your review was requested.

@tahoeblue In the ontology, Organization is a subclass of party and is not defined as a collection. This discussion is about the choice of property on the restriction, hasMember, which has a note on it that says the thing in the domain should be an aggregate or collection. That property does NOT require the class in the domain to be a subclass of Collection, but suggests that the thing in the domain is some sort of aggregate (which may not be a collection) or a collection. But let's discuss in our next meeting. I disagree with Pete that there is an absolute requirement that the domain of the property MUST be a subclass of Collection - the ontology does not make that semantic commitment, which is really the crux of the issue.

And - if we make any change in this regard, it should be done in a separate issue due to the extend of the change.

@tahoeblue
Copy link

tahoeblue commented Jan 25, 2024 via email

Copy link
Contributor

@rivettp rivettp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General change is OK but we need specific issues for use of Collections for Organizations; and LLC ManagingMember semantics.

@rivettp rivettp merged commit e12d0e6 into edmcouncil:master Jan 29, 2024
4 checks passed
@ElisaKendall ElisaKendall deleted the FND-380a branch January 29, 2024 17:16
@mereolog mereolog added this to the 2024Q1 FIBO Release milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Commons Domain consistency About overall consistency enhancement FND FIBO Foundations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FND-380a - Revise / replace several ontologies with their counterparts from the Commons Ontology Library v1.1
5 participants