Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conform-dom,conform-react): automatic button creation for form-level error #69

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

edmundhung
Copy link
Owner

  • This makes conform inserting placeholder buttons for non-field error if no existing elements can be used, e.g. form error.
  • Instead of relying on submit event to reset error due to no invalid event being dispatched by native APIs like form.reportValidity() on field changed to valid state, this is now simplified by dispatching invalid event manually whenever the validationMessage is changed.

@codesandbox
Copy link

codesandbox bot commented Jan 1, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jan 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c1643d
Status: ✅  Deploy successful!
Preview URL: https://695ef478.conform.pages.dev
Branch Preview URL: https://auto-button-creation.conform.pages.dev

View logs

@edmundhung edmundhung merged commit 0d511bf into dev Jan 2, 2023
@edmundhung edmundhung deleted the auto-button-creation branch January 2, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant