Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open_mfdatarray bug fix #208

Merged
merged 3 commits into from Dec 21, 2018
Merged

Open_mfdatarray bug fix #208

merged 3 commits into from Dec 21, 2018

Conversation

edoddridge
Copy link
Owner

The function open_mfdataarray didn't respect the location of the variables on the grid. This PR introduces a test that can detect that behaviour, and a fix for the problem.

Previous behaviour ignored the variable's location on the grid.
Additionally, refactor code for finding grid offsets into private function.
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #208 into master will increase coverage by 0.07%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   90.44%   90.51%   +0.07%     
==========================================
  Files          19       19              
  Lines        1601     1613      +12     
  Branches       82       82              
==========================================
+ Hits         1448     1460      +12     
- Misses        126      127       +1     
+ Partials       27       26       -1
Impacted Files Coverage Δ
aronnax/core.py 95.34% <87.5%> (-0.72%) ⬇️
src/model_main.f90 95.65% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1487ff0...a891957. Read the comment docs.

@edoddridge
Copy link
Owner Author

This pull request introduces 2 alerts when merging 630e6ef into 1487ff0 - view on LGTM.com

new alerts:

  • 1 for Unreachable code
  • 1 for Redundant assignment

Comment posted by LGTM.com

@edoddridge edoddridge merged commit acb738c into master Dec 21, 2018
@edoddridge edoddridge deleted the open_mfdatarray_bug_fix branch March 12, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant