Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active lower layer in reduced gravity mode #241

Merged
merged 7 commits into from Oct 19, 2022

Conversation

edoddridge
Copy link
Owner

Add the capability to have a quiescent upper layer and flow in the bottom layer - an "upside down" 1.5 layer model.

It doesn't do anythign yet, but exists in python and fortran configs.
Some of the indentation was off follwing the snake_case changes (should have been fixed there...)
Can now run with a quiescent upper layer and an active lower layer in 1.5 layer simulations.
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #241 (e99c517) into master (a837cf5) will decrease coverage by 0.68%.
The diff coverage is 47.05%.

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   75.10%   74.41%   -0.69%     
==========================================
  Files          20       20              
  Lines        1390     1419      +29     
  Branches       81       85       +4     
==========================================
+ Hits         1044     1056      +12     
- Misses        299      313      +14     
- Partials       47       50       +3     
Impacted Files Coverage Δ
src/aronnax.f90 30.70% <0.00%> (-2.01%) ⬇️
src/model_main.f90 84.07% <ø> (ø)
src/bernoulli.f90 41.17% <37.50%> (-0.93%) ⬇️
src/state_deriv.f90 80.00% <75.00%> (-1.82%) ⬇️
aronnax/driver.py 92.43% <100.00%> (+0.12%) ⬆️
src/time_stepping.f90 58.94% <100.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@edoddridge
Copy link
Owner Author

Tests added:

  • an active lower layer simulation in which the layer thickness perfectly mirrors the bathymetry. This causes the bounding isopycnal to be flat, and therefore there are no pressure gradients and no motion.
  • an active lower layer simulation with sloping bathymetry and an initial condition with uniform layer thickness. As expected this leads to a gravity driven rearrangement and the fluid moves down slope an the bounding isopycnal flattens over time.

The coverage stats aren't correct. For some reason the execution counts aren't accumulating across all of the tests. I will open an issue about this. In the meantime, this PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant