Add routing view #22
Add routing view #22
Conversation
mmilata
force-pushed
the
routing-view
branch
2 times, most recently
from
3ed1101
to
074cf08
Compare
config/default.go
Outdated
| "DIR", # event type: send, receive, forward | ||
| "STATUS", # one of: active, settled, failed, linkfail | ||
| "IN CHANNEL", # channel id of the incomming channel | ||
| "IN ALIAS", # incoming channel node alias |
There was a problem hiding this comment.
I find it difficult to understand from colum header the limits of each column
maybe It should be better to have underscore: IN_ALIAS in order to have space as a column delimiter only
There was a problem hiding this comment.
README.md should be modified with this new columns and a disclamer about the non persistence of the routing view
There was a problem hiding this comment.
Fixed and added section to README.md. What about LAST UPDATE though?
| @@ -425,6 +480,10 @@ func New(c *config.Network, logger logging.Logger) (*Backend, error) { | |||
| logger: logger.With(logging.String("name", c.Name)), | |||
| } | |||
|
|
|||
| if c.PoolCapacity < lndMinPoolCapacity { | |||
There was a problem hiding this comment.
Yeah my pool has bug, technically we want the pool to create a new connection if there is not enough conn.
Your fix can be added temporally the time to fix it
| } | ||
|
|
||
| func (c *Routing) Speed() (int, int, int, int) { | ||
| current := c.currentColumnIndex() |
There was a problem hiding this comment.
A fix is needed for the cursor. Please, reproduce this change:
https://github.com/edouardparis/lntop/pull/23/files#diff-1a61b9279a10d79e5322cbbc01644da76c7b9e7111de5f718d6fe7a0bc83ec68R140
There was a problem hiding this comment.
Added fix to bc8aabe
|
Thanks for the tip! I currently cannot accept as I don't want this identity publicly linked to my node, but feel free to tip nix-bitcoin instead:) |
ui/views/routing.go
Outdated
| "IN CHANNEL", | ||
| "IN ALIAS", | ||
| "OUT CHANNEL", | ||
| "OUT ALIAS", |
There was a problem hiding this comment.
sorry it is missing _
Columns are not displayed
There was a problem hiding this comment.
Oops, fixed in f0dedd5.
Ignore lower values, lntop won't start with pool_capacity <= 3 due to router rpc handle.
|
Thank you for your contribution ! |
Adds ROUTING view which shows log of HTLC forwards, sends & receives. It is useful for viewing failed forwards which are (AFAIK) not persisted in lnd but can be obtained through streaming api. Not quite sure what the best column order & column colors are:smiley:
Needs #21.