-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thorium Reader is not able to borrow books from an OPDS feed #1148
Comments
Thank you very much for the detailed description of the problem. Thorium does not support PDF publications, so this could be the cause of the behaviour. Would you be able to test with an OPDS feed that serves EPUB publications? |
Absolutely, will do |
Should that be "Thorium does not yet support PDF publications"…? |
@danielweck I tried with an EPUB and updated my repository accordingly but it worked the same way, I wasn't able to download the book |
@vbessonov publish the log, please |
@panaC, sure but I downloaded the Thorium's binary from the website, could you tell me how I can get the logs? |
Unfortunately, it didn't work. Basically, http://localhost:8080/fulfill/ gets rewritten by nginx to http://localhost:8080/fulfill/index.epub anyways |
@panaC, is there anything else I can do to make it work? |
@danielweck, what can I do to speed up the investigation process? |
Sorry, I have been out of office.
|
So far I am not seeing anything suspicious in the OPDS server:
|
EDIT --- see message below (there is a typo in the OPDS feed) @panaC I am seeing this in the console: (note that I added
|
@vbessonov there is a typo in:
|
@panaC when clicking on the EPUB cover, the popup dialog appears and shows the "borrow" link, and a couple of seconds later this gets replaced with an "import" link (presumably, there is an async HTTP fetch to a "publication" dataset, which replaces the default one found in the original OPDS feed). The "import" link works fine. During the 2 seconds gap, if I click on the "borrow" link, it can be opened in the web browser, but not in Thorium. Any idea what is going on? |
2 entry links are extracted from this entry :
the first timeout and the second returns :
the publication information view is updated and display this new entry. There is no more a borrow link but an acquisition link. This is why the view changed. the acceptable mimeType are :
json and jsonld are only accepted when the format is readium web publication manifest (RWPM) to package it. I think this behaviour is standard, and i can close this issue. |
@vbessonov is it finally something NYPL has to correct in its feeds? |
My bad, thorium-reader/src/main/converter/opds.ts Lines 322 to 325 in 57b8183
What do you think @danielweck ? |
I was wrong on the borrow that opens in the browser.
and will be probably fixed with thorium-reader/src/renderer/library/opds/handleLink.ts Lines 25 to 29 in b9426c7
|
- should fixes the second part of the issue #1148
tested with : https://github.com/vbessonov/opds-feed ,, it's works now ! |
I faced with an issue when Thorium Reader is not able to borrow books from an OPDS feed.
The OPDS feed I'm using: https://github.com/vbessonov/opds-feed
Steps to reproduce:
http://localhost:8080
as its URL:Test OPDS feed
catalog and try to borrow a book:borrow
link in a browser and then stops:The books wasn't downloaded and isn't accessible in Thorium Reader:
The text was updated successfully, but these errors were encountered: