-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thorium uses port 8000 #1504
Comments
Hi, our lead dev is currently testing solutions which would allow the removal of the internal http server (which feeds the internal Chromium browser). If successful, this will solve this issue. I didn't check the current port, but in the short term it could certainly be changed for something unused by major frameworks. |
Amazing, thank you 🙏 |
Thorium uses a library that finds an unused port for launching the HTTP server (aka "streamer"): thorium-reader/src/main/redux/sagas/streamer.ts Lines 31 to 33 in 8a9807b
We can set start and end boundaries for the search range, but we cannot exclude commonly-used ports (as far as I know): Once the Electron bugs are solved, we will switch to a non-HTTP "streamer": |
Looking at https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers it is true that finding free places is difficult. |
Do you even need a server? |
@alvinometric see #1258. |
To complete Laurent's answer: yes, Thorium needs to serve audio/video files via HTTP as streaming media is currently broken in Electron's custom URL protocol handler: |
Oh, I see. |
The merged PR enables a new HTTP-less mode in Thorium, which is currently turned off (at build time). We will activate this new feature once video/audio streaming works in Electron |
Because we will move to an HTTP-less mode asap, we will close this issue now. |
It's coming! #1258 (comment) |
👏 |
Hello,
Thank you so much for your work on this app. The Internet badly needs a good, cross-platform ebook reader.
I noticed that Thorium uses port
8000
even when it's downloaded as a standalone app.As a result you can't run code snippets that default to
http://localhost:8000/
like Django (a massively popular Python framework), for example.The text was updated successfully, but these errors were encountered: