Fix bug in SSE2 version of fast detector #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First: 3*w does not hold for grayscale images (!). Second: rowStride may be different than w.
jlblancoc
referenced
this pull request
in MRPT/mrpt
Jan 4, 2019
First: 3*w does not hold for grayscale images (!). Second: rowStride may be different than w.
edrosten
pushed a commit
that referenced
this pull request
Jan 13, 2019
This PR: #47 shows a failure on sub images. Fix the test to highlight the failure
Merged
|
Thanks for the bug report. Turns out stride is the stride for 3 rows at once. I've fixed it in this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @edrosten, Thanks for your great library! 馃憤
Please, take a look at these two commits: one is a minor fix to
-Wshadowwarnings, but the important one is the fix to what seems a bug in the SSE2 code for faster.The bug would reveal only if width!=stride, which might explain it went unnoticed (?). However, I can't explain the
3in3*wfor grayscale images, so I set it torow_stride()anyway.