Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added entry.link template for some feeds (e.g. youtube-rss) #2

Merged
merged 2 commits into from
Sep 29, 2020
Merged

added entry.link template for some feeds (e.g. youtube-rss) #2

merged 2 commits into from
Sep 29, 2020

Conversation

stefangrotz
Copy link
Contributor

@stefangrotz stefangrotz commented Mar 10, 2019

youtube RSS (e.g. https://www.youtube.com/feeds/videos.xml?channel_id=UCsXVk37bltHxD1rDPwtNM8Q) uses link tags instead of entry.id so I added it.

Copy link
Contributor

@htgoebel htgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, which could be merged easily. Just a small change suggestion to improve the manual.

@@ -32,7 +32,7 @@ like so:
Bookmark: {title} {url} {summary}

`{hashtags}` will look for tags in the feed entry and turn them into a space
separated list of hashtags.
separated list of hashtags. For some feeds (e.g. youtube-rss) you should use `{link}` instead of `{url}`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would better fit in front of line 29.

@edsu edsu merged commit 350764b into edsu:master Sep 29, 2020
@edsu
Copy link
Owner

edsu commented Sep 29, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants