Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

I18n: Korean #1191

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

I18n: Korean #1191

wants to merge 6 commits into from

Conversation

minwook-shin
Copy link

I want to support in internationalization support on your roadmap.
So, I added Korean support.

@@ -27,7 +27,7 @@ class Application < Rails::Application
config.i18n.load_path += Dir[Rails.root.join("config", "locales", "**", "*.{rb,yml}")]

# Available locales
I18n.available_locales = [:en]
I18n.available_locales = [:en, :ko]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use %i or %I for an array of symbols.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minwook-shin - Not an error, but code quality standards have been set like this for this project, in the .rubocop.yml file.

So, changing [:en, :ko] -> %i[en ko] would make hound bot happy. 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! @athityakumar !

and @houndci-bot , I modified code for you.

@minwook-shin
Copy link
Author

@tarebyte
Excuse me, Is my PR wrong ...?
If you have forgotten this item, please activate it again. thanks.

@minwook-shin minwook-shin requested a review from d12 October 29, 2017 23:26
@tarebyte
Copy link
Member

@minwook-shin my apologies, I've been super busy and haven't had time to look at this.

I'm trying to find someone to validate your translation https://twitter.com/tarebyte/status/919958270550388736

@minwook-shin
Copy link
Author

@tarebyte , okay, I will wait for validating.
Thanks for answer! :)

@minwook-shin
Copy link
Author

I fixed the Korean translation. (some typos)

@minwook-shin
Copy link
Author

Did you get someone to verify Korean translation?

@stale
Copy link

stale bot commented Sep 25, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 25, 2018
@stale
Copy link

stale bot commented Dec 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants