Revisiting Invitation Pages after accepting the invitation

[tarebyte]

This closes #144 and closes #143.

When a student accepts an invitation to an assignment individual or group it will redirect them as expected.

But if they try to accept that same invitation again, it should automatically show them their assignment URL.

Looking for code feedback, and thoughts.

/cc @johndbritton

[tarebyte]

This is what it currently looks like when a student accepts an individual assignment.

[johndbritton]

The flow looks right to me. Planning to tackle the design issues separately?

[johndbritton]

I think this resolves #143, but I don't know if it fully addresses #144. Since this is a new assignment, you might have the case where the group member previously accepted assignment A and formed teams, but has not accepted assignment B (which is using the same group of teams).

[tarebyte]

May as well tackle the design here as well.

[tarebyte]

@johndbritton how does this look for the individual assignment invitation page?

[johndbritton]

@tarebyte I think you should include the full app chrome with "Classroom for GitHub," organization name, and assignment name heading sections and the info and actions inside that:

For the copy, how about this:

Accepting this assignment will give you access to the repository-name repository in the organization-name organization on GitHub.

[johndbritton]

I don't think it's necessary to explain that it will be created if it hasn't already been and that they will be given access if they haven't been. Telling them the end result should be clear enough.

[tarebyte]

@johndbritton better?

[johndbritton]

❤️ Looks great.

[tarebyte]

@johndbritton merging this for now, shout if you have any feedback!