This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[Idea] Sleep until rate limit updates and try again #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 11, 2018
| rescue GitHub::TooManyRequests | ||
| retries ||= 0 | ||
| if retries < 1 | ||
| retries +=1 |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Surrounding space missing for operator +=.
| rescue GitHub::TooManyRequests | ||
| retries ||= 0 | ||
| if retries < 1 | ||
| retries +=1 |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Surrounding space missing for operator +=.
|
Maybe we could move the sleep / retry logic into the |
Yeah that seems reasonable to me 👍 |
BenEmdon
reviewed
Oct 11, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on updating ES indexes, I'm slightly worried about exhausting some rate limits.
This is just an idea for how we could rescue from a hitting our rate limits, hold off for a cool down period, and then resume work.
If something like this would work, I think it might be worth defaulting to not behaving this way and implementing a way to choose the behavior, similar to how we can choose to skip the API cache.
cc/ @d12 @tarebyte for your opinions on the approach.