Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Added method for creating organization webhooks #1709

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Added method for creating organization webhooks #1709

merged 1 commit into from
Dec 7, 2018

Conversation

BenEmdon
Copy link
Contributor

This PR proposes we add the following methods on OrganizationWebhook:

  • create_org_hook!: Creates an organization webhook, and saves it's ID.
  • webhook_url Get the proper webhook url.

Part of #1647

  • move the logic for creating a webhook from the Organization::Creator to GitHubOrganizationWebhook

Incorporating this in the Organization::Creator will come in a follow up PR.

@BenEmdon BenEmdon mentioned this pull request Dec 3, 2018
Merged
srinjoym
srinjoym approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@srinjoym srinjoym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@BenEmdon BenEmdon requested a deployment to production December 7, 2018 18:25 Abandoned
@BenEmdon BenEmdon merged commit 4f65828 into master Dec 7, 2018
@BenEmdon BenEmdon deleted the create_githuborghook branch December 7, 2018 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srinjoym srinjoym srinjoym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenEmdon @srinjoym