Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Move other search over to new markup #2393

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

JessRudder
Copy link
Contributor

@JessRudder JessRudder commented Sep 27, 2019

In order to add multiple filters for the classroom page (to enable filtering by whether or not a class was archived), I had to create separate search/filtering code (the existing code was very reliant on there only being one filter option and we now needed two).

The initial plan was to leave both sets of search/filter in place side by side until there was a reason to move the old code over. I discovered that the existing search (visible on assignment and group assignment pages) is only partially functional so it seemed like the right time to fix and unify the code.

This PR:

  • Switches assignment/group assignment views to use new search/filter markup
  • Gets assignment/group assignment filter/search to use same JS as the classroom index
  • Fixes filtering bug when someone chooses Created at:
  • Fixes bug in new search implementation that was preventing debouncing from happening
  • Moves markup into reusable partials (maybe...we'll see if this makes sense once things are in place)

@JessRudder JessRudder added the WIP 💭 PR's that are a 'Work In Progress' label Sep 27, 2019
@JessRudder JessRudder self-assigned this Sep 27, 2019
@JessRudder JessRudder added this to In progress in GitHub Classroom via automation Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🪲 WIP 💭 PR's that are a 'Work In Progress'
Projects
GitHub Classroom
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants