-
Notifications
You must be signed in to change notification settings - Fork 565
Support special characters for Assignments #410
Conversation
@johndbritton the more I think about this, the more I believe we should not support special characters. We should instead handle them how GitHub does, for example an Ü becomes a -. This means that we should also add some client side warnings so that the user knows what they're assignment name will be. What do you think? |
We shouldn't change user input, so if the title includes special characters, we should display them (as GitHub does). I'm fine with replacing special characters in URL slugs, though. |
Names of assignments aren't GitHub Repo names. This is a perfect example, the assignment name should be able to use special characters even if the repository cannot. If anything, I think this is another reason why we shouldn't put the assignment name in the URL and potentially another reason to get rid of |
Except for the fact that we create the repo names based on the name of the assignment. Is there another way we could make these names? |
Perhaps we create a |
We already have the
That is very doable, I'm 👍 for it. |
7c65a5d
to
9968704
Compare
# Conflicts: # Gemfile.lock
Closes #266