Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Support special characters for Assignments #410

Closed
wants to merge 4 commits into from

Conversation

tarebyte
Copy link
Member

Closes #266

@tarebyte
Copy link
Member Author

@johndbritton the more I think about this, the more I believe we should not support special characters.

We should instead handle them how GitHub does, for example an Ü becomes a -. This means that we should also add some client side warnings so that the user knows what they're assignment name will be.

What do you think?

@johndbritton
Copy link
Contributor

We shouldn't change user input, so if the title includes special characters, we should display them (as GitHub does). I'm fine with replacing special characters in URL slugs, though.

@tarebyte
Copy link
Member Author

I agree about still displaying special characters, the thing is though GitHub repos don't support special characters. It just replaces everything with one dash.

This is an example of that scenario right now.

screen shot 2015-12-21 at 6 51 59 am

Maybe we should warn the user when they make the title, something similar to this.

screen shot 2015-12-21 at 6 54 04 am

@johndbritton
Copy link
Contributor

the thing is though GitHub repos don't support special characters.

Names of assignments aren't GitHub Repo names. This is a perfect example, the assignment name should be able to use special characters even if the repository cannot.

If anything, I think this is another reason why we shouldn't put the assignment name in the URL and potentially another reason to get rid of title all together.

@johndbritton
Copy link
Contributor

Names of assignments aren't GitHub Repo names.

Except for the fact that we create the repo names based on the name of the assignment. Is there another way we could make these names?

@johndbritton
Copy link
Contributor

Perhaps we create a slug field that is used to generate the repo name on GitHub and allow teachers to set that. If we wanted to get fancy, you could display two fields title and slug and have the slug field auto-populated but editable by the user.

@tarebyte
Copy link
Member Author

Perhaps we create a slug field that is used to generate the repo name on GitHub and allow teachers to set that.

We already have the slug column on those models so we could add those to the form.

If we wanted to get fancy, you could display two fields title and slug and have the slug field auto-populated but editable by the user.

That is very doable, I'm 👍 for it.

@tarebyte tarebyte added development WIP 💭 PR's that are a 'Work In Progress' and removed development labels Jan 6, 2016
@tarebyte tarebyte self-assigned this Jan 6, 2016
@dinever dinever assigned dinever and unassigned tarebyte Aug 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants