Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Update og-image to GitHub Classroom #566

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Update og-image to GitHub Classroom #566

merged 1 commit into from
Apr 14, 2016

Conversation

cyhsutw
Copy link
Contributor

@cyhsutw cyhsutw commented Apr 14, 2016

Fixes #565.

I've changed the title text of the og-image to GitHub Classroom.

Here's how it looks like now:

og-image

@tarebyte
Copy link
Member

@cyhsutw thanks for the contribution!

I think the text color is off a bit (needs to be #9FD1AF) and the also make sure that we are using the latest octicons.

@johndbritton
Copy link
Contributor

@tarebyte The wordmark was pure white in the previous version as well I think. This is slightly different than what we had, but I think it works.

We'll likely revisit the share image when we update the homepage.

@tarebyte
Copy link
Member

@johndbritton 🆒 that's fine. :shipit:

@tarebyte tarebyte merged commit 926af85 into education:master Apr 14, 2016
@cyhsutw
Copy link
Contributor Author

cyhsutw commented Apr 16, 2016

Update:

I triggered the crawling process manually after this PR was merged.
However, it does not update the og:image immediately.
After two days, Facebook finally refreshed the cache, and the new image is now live.

screen shot 2016-04-16 at 8 47 30 pm

According to this StackOverflow question, I think maybe we can change the name of the image a little bit if we need to update the og:image so the crawler will replace the cache immediately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants