Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Basic auth is not working for domain subdirectories? #32

Closed
humpfle opened this issue Oct 25, 2016 · 14 comments
Closed

Bug: Basic auth is not working for domain subdirectories? #32

humpfle opened this issue Oct 25, 2016 · 14 comments

Comments

@humpfle
Copy link

humpfle commented Oct 25, 2016

Basic auth is not working properly for subdirectories, i.e. if the files are stored in: host.de/subdirectory

Maven App URL configuration;

<app.url>http://user:password@host.de/subdirectory</app.url>

=> With this configuration, an exception occurs: FileNotFoundException: http://user:password@host.de/someJar.jar

It seems that the subdirectory is ignored.

I´ve found out that there is a workaround by extending the maven <app.url> configuration

<app.url>http://user:password@host.de/subdirectory/**any_string_workaround**</app.url>

=> Now the path host.de/subdirectory seems to be resolved correctly

@edvin
Copy link
Owner

edvin commented Oct 25, 2016

Can you try to simply add a trailing / to the URL?

http://user:password@host.de/subdirectory/

Can you also tell me which version of FXLauncher you are using?

@humpfle
Copy link
Author

humpfle commented Oct 25, 2016

ok, i´ve found the solution:

the configuration must be http://user:password@host.de/subdirectory**/**
instead of http://user:password@host.de/subdirectory

sorry for any circumstances.

(now i got server 401 although the creditials works in the browser, but thats another issue)

@edvin
Copy link
Owner

edvin commented Oct 25, 2016

What version of FXLauncher are you using?

@edvin
Copy link
Owner

edvin commented Oct 25, 2016

And can you possibly send me the URL with a working username and password so I can try it?

@humpfle
Copy link
Author

humpfle commented Oct 25, 2016

I´m using version 1.0.13

@edvin
Copy link
Owner

edvin commented Oct 25, 2016

Great. I have found the error and I'm working on it now :)

@humpfle
Copy link
Author

humpfle commented Oct 25, 2016

ok, i guess you don´t need the user/pass anymore?!

@edvin
Copy link
Owner

edvin commented Oct 25, 2016

Probably not :) Hang on!

@edvin
Copy link
Owner

edvin commented Oct 25, 2016

I have committed a fix for this is 1.0.14-SNAPSHOT. Do you know how to build from source and try this?

@edvin
Copy link
Owner

edvin commented Oct 25, 2016

Attached is version 1.0.14-SNAPSHOT with the fix (unzip to get the jar, unable to upload jars directly to GitHub). You can install it into your local Maven repo like this:

mvn install:install-file -Dfile=fxlauncher-1.0.14-SNAPSHOT -Dversion=1.0.14-SNAPSHOT -Dpackaging=jar -DgroupId=no.tornado -DartifactId=fxlauncher

After that you should be able to update to version 10.0.14-SNAPSHOT in your project, do a clean build and try it. Let me know how it goes, OK? :)

fxlauncher-1.0.14-SNAPSHOT.zip

@humpfle
Copy link
Author

humpfle commented Oct 25, 2016

yes i can check it out and build a snapshot, thanks

@edvin
Copy link
Owner

edvin commented Oct 25, 2016

Perfect, thank you! I need to get to bed now. If it works I'll release 1.0.14 tomorrow after doing some more quality tests, it's getting late here in Norway :)

@humpfle
Copy link
Author

humpfle commented Oct 25, 2016

the snapshot version 1.0.14 is working great! thanks and good night

@edvin
Copy link
Owner

edvin commented Oct 26, 2016

Version 1.0.14 is now in Maven Central. Thank you for the bug report and your patience.

@edvin edvin closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants