Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace right drawer cannot be opened when floating is set to true #1163

Closed
SKeeneCode opened this issue Feb 11, 2020 · 7 comments
Closed

Comments

@SKeeneCode
Copy link

SKeeneCode commented Feb 11, 2020

Try the following example. Right click and change the drawer to be floating and it will close and cannot open.

Minimal example:

fun main(args: Array<String>) {
    launch<MyTestApp>(args)
}


class MyTestApp: App(WorkSpaceTest::class) {
    override fun onBeforeShow(view: UIComponent) {
        workspace.dockInNewScope<TestPage>()
    }
}

class WorkSpaceTest : Workspace("Workspace")

class TestPage: View("My Test Page") {
    override val root = pane {}

    override fun onDock() {
        with(workspace.rightDrawer) {
            item("Drawer Item") {
                add(myDrawer::class)
            }
        }
    }
}

class myDrawer: View() {
    override val root = pane {
        prefWidth = 100.0
    }

}
@bykka
Copy link
Contributor

bykka commented Feb 12, 2020

@SKeeneCode Don't forget please to include information about version's of libraries and JDK

@SKeeneCode
Copy link
Author

Of course:

Java 13, JavaFX 13, TornadoFX-2.0.0-SNAPSHOT

@SchweinchenFuntik
Copy link
Contributor

SchweinchenFuntik commented Feb 12, 2020

tried various variations yesterday - it is reproduced. version TornadoFX 1.7.19

@edvin
Copy link
Owner

edvin commented Feb 17, 2020

Thanks for reporting. I've committed a fix in 1.7.21-SNAPSHOT, will port to 2.0.0-SNAPSHOT as well.

@edvin
Copy link
Owner

edvin commented Feb 17, 2020

Hm, actually not sure how to merge changes from the master branch to the jdk10 branch. Anyone? :)

@SchweinchenFuntik
Copy link
Contributor

I'll try to see if I can unsubscribe

@SKeeneCode
Copy link
Author

Closing as this has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants