Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to correctly remove the row from the GridPane, as well as remove all rows #801

Open
zshamrock opened this issue Sep 15, 2018 · 0 comments
Open

Add support to correctly remove the row from the GridPane, as well as remove all rows #801

zshamrock opened this issue Sep 15, 2018 · 0 comments

Comments

@zshamrock
Copy link
Contributor

The problem with the removing manually is that you have to use (and so be aware) of the internal TornadoFX.GridPaneRowId property which manages the row index internally.
zshamrock added a commit to zshamrock/tornadofx that referenced this issue Sep 15, 2018
@zshamrock
edvin#801 Add support to remove row from the GridPane
0203f6d 
As well as remove all rows.
zshamrock added a commit to zshamrock/tornadofx that referenced this issue Sep 15, 2018
@zshamrock
edvin#801 Reset row and column indexes on the children removed
c8e2b3a 
Also added the unit tests to verify the behavior.
zshamrock added a commit to zshamrock/tornadofx that referenced this issue Sep 15, 2018
@zshamrock
edvin#801 Fit with the project import style
d89bbad
zshamrock added a commit to zshamrock/tornadofx that referenced this issue Sep 15, 2018
@zshamrock
edvin#801 Simplify unit test by adding tests for the add rows
59212b5
zshamrock added a commit to zshamrock/tornadofx that referenced this issue Sep 16, 2018
@zshamrock
edvin#801 Remove the grid row id key property on when removing the si…
5118b48 
…ngle row

Thinking more it feels like the better approach to remove the property rather than going to -1 value.
edvin pushed a commit that referenced this issue Sep 18, 2018
Merge pull request #802 from zshamrock/master
b656f9a 
#801 Add support to remove row from the GridPane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zshamrock